ShipIt Clean — 997d0a7c95b7

Total Findings

High

main @ 7faebe1

AIAI Threat Analysis

REAL THREATS

Supply Chain & External Resource Risks

• Finding 0 (HIGH): scripts/find-resources.sh fetches external URLs without integrity verification. An attacker could compromise the linked resources (e.g., via DNS hijacking, compromised CDN) to serve malicious content, leading to supply chain attacks against developers using these learning resources.

• Finding 13 (HIGH): Related domino cascade - if external URLs become unavailable (link rot, takedowns), the learning framework's value degrades, but more critically, it could be replaced with malicious mirrors that developers might trust.

Path Traversal & Input Validation

• Finding 1 (HIGH): scripts/generate-deep-dive.sh accepts user-controlled file paths without validation (line 10: FILES=("$@")). An attacker could inject paths like ../../../etc/passwd or ../../.env, potentially exposing sensitive files.

• Finding 12 (CRITICAL): The domino cascade from finding 1 - legitimate file paths containing .. (common in codebases) will break the analysis script, causing denial of service for the learning framework. This also enables path traversal if output is written to unexpected locations.

ATTACK CHAINS

1. External Resource Compromise → Supply Chain Attack: An attacker compromises one of the curated resource domains (e.g., react.dev, typescriptlang.org via DNS hijacking). The find-resources.sh script serves malicious links to developers, who then visit compromised sites that could deliver malware or phishing content.

2. Path Traversal → Sensitive Data Exposure: User provides ../../../etc/passwd as a "file to analyze" → script reads and potentially includes sensitive system file contents in the generated deep-dive markdown, which could be exposed if shared or published.

VERDICT

Two critical issues require immediate attention:

1. Path traversal in generate-deep-dive.sh (Finding 12/1): Must validate and sanitize all file path inputs. Restrict to current directory subtree and validate file extensions.

2. External resource integrity (Finding 0/13): Implement checksum verification or use locally cached, vetted resources. At minimum, warn users that external links aren't verified.

The other findings are false positives: they flag missing security features (SBOM, signing, validation) in helper scripts that are not exposed to untrusted users in production. These scripts are internal tools for generating educational content, not production services.

2 raw scanner findings — 2 high

▶ Raw Scanner Output — 7 pre-cleanup findings

⚠ Pre-Cleanup Report
This is the raw, unprocessed output from all scanner agents before AI analysis. Do not use this to fix issues individually. Multiple agents attack from different angles and frequently report the same underlying vulnerability, resulting in significant duplication. Architectural issues also appear as many separate line-level findings when they require a single structural fix.

Use the Copy Fix Workflow button above to get the AI-cleaned workflow — it deduplicates findings, removes false positives, and provides actionable steps. This raw output is provided for transparency and audit purposes only.

HIGHNo dependency integrity verification on external resources

[redacted]/find-resources.sh:1

[AGENTS: Supply]supply_chain

Script outputs external URLs without any integrity verification (checksums, signatures, or validation). If script is modified or compromised, users could be directed to malicious resources without detection.

Suggested Fix

Add checksum verification for all external resources before outputting them. Implement signature verification where available.

HIGHUnvalidated file paths from user input

[redacted]/generate-deep-dive.sh:10

[AGENTS: Chaos]path_traversal

FILES array accepts user-provided paths without validation. An attacker could potentially use path traversal (../) to access files outside intended scope if this script is used in a more complex pipeline.

Suggested Fix

Validate file paths: for FILE in "${FILES[@]}"; do if [[ "$FILE" == *".."* ]]; then echo "Invalid path: $FILE"; exit 1; fi; done

HIGH[Domino] External resource URLs will become unavailable

[redacted]/find-resources.sh:1

[AGENTS: domino-scanner]domino_cascade

The script outputs curated external URLs (e.g., https://react.dev, https://jwt.io) as learning resources. Adding checksum verification for these URLs will break the script because: 1) URLs don't have checksums, 2) The script doesn't download resources - it only outputs links, 3) The case statements output hardcoded strings, not external files. The fix misunderstands the script's purpose and will make it unusable.

Suggested Fix

Remove this fix - it's not applicable. The script outputs curated reference URLs, not downloading external resources. If integrity verification is needed, implement it in a separate download script that fetches actual resources.

LOWNo secure secrets handling in hooks configuration

[redacted]/hooks.json:1

[AGENTS: Supply]supply_chain

Hook configuration may contain sensitive prompts or instructions. No encryption or secrets management for sensitive hook data.

Suggested Fix

Implement secrets encryption for sensitive hook configurations. Use environment variables for any sensitive data.

LOWFile discovery may miss concurrent changes

[redacted]/capture-phase.sh:13

[AGENTS: Chaos]race_condition

The -mmin -60 flag captures files modified in the last hour, but if multiple processes modify files concurrently, some changes may be missed or captured twice.

Suggested Fix

Consider using git diff or more precise timestamp tracking for production use

LOWTemplate lacks security metadata fields

[redacted]/deep-dive.md:1

[AGENTS: Supply]supply_chain

Template does not include security-related metadata fields (SBOM reference, provenance, integrity hash, signing key ID).

Suggested Fix

Add security metadata section to template: SBOM reference, provenance hash, signing information, integrity verification instructions.

CRITICAL[Domino] Legitimate file paths with '..' will break analysis

[redacted]/generate-deep-dive.sh:10

[AGENTS: domino-scanner]domino_cascade

The proposed fix rejects ANY file path containing '..', but the script processes files from user input or find commands that may legitimately contain '..' in directory names (e.g., '../src', '../../lib'). This will cause the script to exit with 'Invalid path' error for valid relative paths, breaking the entire deep-dive generation for projects with such directory structures.

Suggested Fix

Validate paths using realpath or check if the resolved path is within the current working directory: if [[ "$(realpath -- "$FILE" 2>/dev/null)" != "$(realpath -- "$PWD" 2>/dev/null)/"* ]]; then echo "Invalid path: $FILE"; exit 1; fi

Note: Fixing issues can create a domino effect — resolving one finding often surfaces new ones that were previously hidden. Multiple scan-and-fix cycles may be needed until you’re satisfied no further issues remain. How deep you go is your call.